Make sure we don't allow fields as values

elixir-mongo · Dec 15, 2015 · 15e6c65 · 15e6c65
1 parent ed24a5e
commit 15e6c65
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/mongo_ecto/conversions.ex b/lib/mongo_ecto/conversions.ex
@@ -44,8 +44,10 @@ defmodule Mongo.Ecto.Conversions do
     do: document(keyword, pk)
   def from_ecto_pk(list, pk) when is_list(list),
     do: map(list, &from_ecto_pk(&1, pk))
-  def from_ecto_pk(value, _pk),
+  def from_ecto_pk(value, _pk) when is_literal(value),
     do: {:ok, value}
+  def from_ecto_pk(value, _pk),
+    do: :error
 
   defp document(doc, pk) do
     map(doc, fn {key, value} ->

diff --git a/lib/mongo_ecto/utils.ex b/lib/mongo_ecto/utils.ex
@@ -7,4 +7,10 @@ defmodule Mongo.Ecto.Utils do
       unquote(doc) |> hd |> tuple_size == 2
     end
   end
+
+  defmacro is_literal(value) do
+    quote do
+      is_atom(unquote(value)) or is_number(unquote(value)) or is_binary(unquote(value))
+    end
+  end
 end