Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container props passed to Stage are not applied #38

Closed
michalochman opened this issue Feb 26, 2018 · 1 comment
Closed

Container props passed to Stage are not applied #38

michalochman opened this issue Feb 26, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@michalochman
Copy link
Owner

Description

Members normally passed to PIXI.Container should be consumed by Stage component but they aren't.

Steps to reproduce

  1. Render <Stage scale={2} />.
  2. See that the stage is not scaled correctly.

Additional info

  • react-pixi-fiber version: 0.3.1
  • React version: 16.2.0
  • ReactDOM version: 16.2.0
  • PixiJS version: 4.7.0
@michalochman
Copy link
Owner Author

The solution would be to applyProps to Stage on componentDidMount and componentDidUpdate. However, because Stage renders both a PixiJS Container and DOM canvas we need to differentiate between props that need to apply to both. We could probably use keys from StagePropTypes and DEFAULT_PROPS objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant