Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 21.10 (Gnome 40): Option "click-action: minimize-or-previews" doesn't show preview of multiple windows #1545

Closed
mirao opened this issue Oct 16, 2021 · 5 comments

Comments

@mirao
Copy link

mirao commented Oct 16, 2021

It seems to be a regression in Gnome 40 (or in Ubuntu 21.10 where I upgraded from 21.04 recently).
It worked for me in Ubuntu 21.04 (Gnome 3.38)

Steps to reproduce:

  1. Dconf editor: Set the value minimize-or-previews in /org/gnome/shell/extensions/dash-to-dock/click-action
  2. Start a few application windows, e.g. VSCode or Gnome Terminal
  3. Switch to another application
  4. Click on the VSCode icon in dock

Expected result:

  • Preview of all VSCode windows is shown

Actual result:

  • One of app's windows is focused, no preview is shown 🐞
  • Then if you click to dock again, the app goes to background (is minimized) which is correct ✔️

I noticed that there is a similar option focus-minimize-or-previews which causes focusing of app and then one more click shows previews ✔️ . However I would like to use minimize-or-previews - I'm used to focus specific window manually by selecting of window in preview.

Used SW:

  • Ubuntu 21.10
  • Gnome Shell 40.5-1ubuntu2
  • Ubuntu Dock 69
@mirao
Copy link
Author

mirao commented Oct 16, 2021

One of app's windows is focused, no preview is shown

Maybe related to #1358 (comment) ?

@pbogaard
Copy link

I am experiencing exactly the same. Just upgraded from the 20.04 Ubuntu version. It was working there.

@pbogaard
Copy link

pbogaard commented Oct 27, 2021

Hurah! I found the bug. Apparently the bug was with ubuntu-dock.

Here is the solution:

In /usr/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/appIcons.js at line 472:

change
const singleOrUrgentWindows = windows.length === 1 || !hasUrgentWindows;
to
const singleOrUrgentWindows = windows.length === 1 || hasUrgentWindows;

(basically removing the ! sign before hasUrgentWindows)

Then log-out & log-in again.

@mirao
Copy link
Author

mirao commented Oct 27, 2021

@pbogaard The fix works, thanks!
Well, the bug was reported also to Ubuntu's gnome-shell-extension-ubuntu-dock here.
It seems that the latest https://github.com/micheleg/dash-to-dock/blob/master/appIcons.js has it already fixed:

const singleOrUrgentWindows = windows.length === 1 || hasUrgentWindows;

Maybe only the Ubuntu package gnome-shell-extension-ubuntu-dock uses broken version?

@mirao
Copy link
Author

mirao commented Oct 27, 2021

@pbogaard As for a fix to gnome-shell-extension-ubuntu-dock, it should be possible to fork Ubuntu repo and propose a fix. Here are specific instructions, if you sign up to Launchpad: https://code.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock

@3v1n0 3v1n0 added this to the ubuntu-22.04 milestone Nov 4, 2021
@3v1n0 3v1n0 closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants