New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 2.7 installation is broken #102
Comments
Tahoe-LAFS CI is now almost entirely failing because of this issue. |
datadog and pytest packages install with pip2 fails because of this issue |
Ech, a new release just before the Easter... I guess many people will get surprise after coming from Holidays/PTO ;-) My tests for legacy builds are also failing due to this, though I am not even sure which package requires decorator as dependency. |
So I saw that the 5.0.1 release was uploaded with the proper From my experience on other projects getting that issue, I would bet this is caused by performing the upload using an old Hoping you'll be able to get out of the Python 2 realm with peace of mind with that done :) |
@vphilippon damn, I dug through nearly half of pip codebase until I realized it's not taken from Thanks for the insight, would've saved me a lot of time if I read it first 😄. |
The uploaded wheel file name lists https://pypi.org/project/decorator/5.0.1/#files I tried building several ways and didn't get
Of course that was with everything updated, so perhaps it is outdated |
Uploaded release 5.0.2, let's hope this is the good one... |
edit: updated to include updating $ virtualenv -p python2 venv2
created virtual environment CPython2.7.18.final.0-64 in 78ms
creator CPython2Posix(dest=/home/altendky/venv2, clear=False, no_vcs_ignore=False, global=False)
seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/altendky/.local/share/virtualenv)
added seed packages: pip==20.3.1, setuptools==44.1.1, wheel==0.36.1
activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator $ venv2/bin/pip install --upgrade pip setuptools wheel
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting pip
Using cached pip-20.3.4-py2.py3-none-any.whl (1.5 MB)
Requirement already up-to-date: setuptools in ./venv2/lib/python2.7/site-packages (44.1.1)
Collecting wheel
Using cached wheel-0.36.2-py2.py3-none-any.whl (35 kB)
Installing collected packages: pip, wheel
Attempting uninstall: pip
Found existing installation: pip 20.3.1
Uninstalling pip-20.3.1:
Successfully uninstalled pip-20.3.1
Attempting uninstall: wheel
Found existing installation: wheel 0.36.1
Uninstalling wheel-0.36.1:
Successfully uninstalled wheel-0.36.1
Successfully installed pip-20.3.4 wheel-0.36.2 $ venv2/bin/pip install decorator
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting decorator
Using cached decorator-5.0.2.tar.gz (33 kB)
ERROR: Command errored out with exit status 1:
command: /home/altendky/venv2/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-YVO1qP/decorator/setup.py'"'"'; __file__='"'"'/tmp/pip-install-YVO1qP/decorator/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-tf8mF2
cwd: /tmp/pip-install-YVO1qP/decorator/
Complete output (8 lines):
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-install-YVO1qP/decorator/setup.py", line 4, in <module>
exec(open('src/decorator.py').read(), dic) # extract the __version__
File "<string>", line 162
print('Error in generated code:', file=sys.stderr)
^
SyntaxError: invalid syntax
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output. |
I observe the same issue as @altendky on Python 2.7.5 with pip==20.3.4 and setuptools-44.1.1. |
I confirm, same issue as @altendky for my setup as well with 5.0.2 |
Sorry if I am being thick, but the point of version 5 of the decorator module was to drop support for Python 2.7, so it is right if it does not work with it. |
So from the pypi.org page (https://pypi.org/project/decorator/), you can see that So that's a tell that for some reason, the metadata isn't sent to pypi.org. My best bet was the version of setuptools/twine used to upload the package, but if @micheles you can assure us you used the latest version of If you can share the versions that were used to perform the upload (like Edit: To be clear: even if the |
I have installed the latest twine and then run
Published 5.0.3 |
Sorry... Looks to be working now. $ virtualenv -p python2 venv2
created virtual environment CPython2.7.18.final.0-64 in 77ms
creator CPython2Posix(dest=/home/altendky/venv2, clear=False, no_vcs_ignore=False, global=False)
seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/altendky/.local/share/virtualenv)
added seed packages: pip==20.3.1, pip==20.3.4, setuptools==44.1.1, wheel==0.36.1, wheel==0.36.2
activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator $ venv2/bin/pip install --upgrade pip setuptools wheel
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Requirement already up-to-date: pip in ./venv2/lib/python2.7/site-packages (20.3.4)
Requirement already up-to-date: setuptools in ./venv2/lib/python2.7/site-packages (44.1.1)
Requirement already up-to-date: wheel in ./venv2/lib/python2.7/site-packages (0.36.2) $ venv2/bin/pip install decorator
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting decorator
Using cached decorator-4.4.2-py2.py3-none-any.whl (9.2 kB)
Installing collected packages: decorator
Successfully installed decorator-4.4.2 |
According to my test (and the pypi.org page) this worked :) . It seems you're happily out of the Py2 realm! |
So much has changed in the Python packaging ecosystem and since I do a release per year I was still following the old ways. |
Since you dropped python 2 support, you have to stop making universal wheels for this module, otherwise pypi is offering wrong version for python2 setups.
I see that this was addressed in commit 50fa96b
Please push new version to pypi, otherwise we are having issues with installation on python2.
The text was updated successfully, but these errors were encountered: