Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZXing.CoreCompat.System.Drawing and VS 2017 #20

Closed
ghost opened this issue May 28, 2017 · 4 comments
Closed

ZXing.CoreCompat.System.Drawing and VS 2017 #20

ghost opened this issue May 28, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented May 28, 2017

FYI An internal error occurred. Please contact Microsoft Product Support Services.

basically i need to show QRCode (.NETCoreApp 1.1) and thought the ASP.NetCoreDemo is a good start but it requires ZXing.CoreCompat.System.Drawing

is there any other possibility to display a QRCode without ZXing.CoreCompat.System.Drawing ?

@micjahn
Copy link
Owner

micjahn commented May 28, 2017

With v0.15.0 there are only two renderes available, SVG and pixel data (raw data, BGRA). Next version provides different bindings for other imaging libraries as separate NuGet packages. At the moment you can find them in the source code repository under the path Source/adapters.
Do you miss something?

@ghost
Copy link
Author

ghost commented May 28, 2017

i have missed working samples and good documentation but meanwhile i was able to produce what i needed but i am not happy to use ZXing.CoreCompat.System.Drawing which uses the same namespace like some Microsoft libraries and i would love to see no error messages if i open the source...

@micjahn
Copy link
Owner

micjahn commented May 29, 2017

I'm not sure what you mean. All samples are working. A good documentation is missing, that's true. You don't have to use CoreCompat.System.Drawing (it's not a ZXing library, it's a third party component because ASP.Net Core doesn't contain image classes (https://github.com/CoreCompat/CoreCompat)). I can't influence the namespace.
You can use any other imaging library which is available for ASP.Net Core. For some of them there are ready-to-use extensions in the repository available.
And if you mean with "... love to see no error messages ..." that you open the VS2015 solution/project with VS2017 and it throws an error, what should I say, I can't guarantee that every hard work of mine, which I provide for free and which is built with VS2015, will work in the future with VS2017, VS2018, VS2019...

@micjahn micjahn closed this as completed May 29, 2017
@kaburkett
Copy link

what you really should say is 'if you want to create a pull request with a fix for vs2017 I will review and merge'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants