Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange indentation #23

Closed
bsoja opened this issue Jun 9, 2017 · 5 comments
Closed

Strange indentation #23

bsoja opened this issue Jun 9, 2017 · 5 comments

Comments

@bsoja
Copy link

bsoja commented Jun 9, 2017

Hi, I noticed you are using strange indentation in files - 3 spaces. Is it intentional or issue caused by auto conversion or sth?

Edit: I found many other code formatting issues and inconsistency, for example below there aren't spaces between arithmetic operators:

float q = distance(poutd, pouta)*nbCenterLayers/(distance(pind, pina)*(nbCenterLayers + 2));

but sometimes even in the same file, spaces appeared:

var pinax = new ResultPoint(pina.X + 0.5f, pina.Y - 0.5f);

@micjahn
Copy link
Owner

micjahn commented Jun 9, 2017

I wouldn't say that the indentation is strange. It is historical. When I started writing code for my first employer I had to use 3 spaces. I never changed it in the last more than 15 or 20 years.

The other inconsistency is related to the java conversion tasks. It doesn't matter for me. Sometimes if I had to fix something in a file I do reformatting the part which I have to fix.

@dave-c-whitney
Copy link

Visual Studio can automatically re-indent to the contemporary standard of 4 spaces. It'll also apply spacing around operators, etc.

@micjahn
Copy link
Owner

micjahn commented Sep 10, 2017

The main question is what is the most common standard? If I change it to 4 spaces, someone will explain that tabulators are better or more standard. My (own) good old standard with whom I started was 3 spaces.

@dave-c-whitney
Copy link

Whatever you prefer, I guess. I've been a professional software engineer for more than 25 years and we've always used 4 spaces. It's what I'm used to, it's what VS keeps pushing whenever I type a close brace. Any edits I hope to contribute here will likely get re-indented. Re-indent as you like, of course.

micjahn added a commit that referenced this issue Jun 28, 2018
reformatted (most of) all files to default of 4 spaces, added .editorconfig
@micjahn
Copy link
Owner

micjahn commented Jul 15, 2018

Indentation changed to 4 white spaces. Added .editorconfig.

@micjahn micjahn closed this as completed Jul 15, 2018
Redth pushed a commit to Redth/ZXing.Net that referenced this issue Dec 13, 2018
reformatted (most of) all files to default of 4 spaces, added .editorconfig
kaypeter87 added a commit to kaypeter87/ZXing.Net that referenced this issue Sep 10, 2019
* micjahn#78 .Net Standard 2.0

* micjahn#89 Some questions when I using Shift_JIS and Mode.Byte to generate a QR Code.

* micjahn#90 Unity (Android) Implementation
* don't use RegexOptions.Compiled

* moving on to VS 2017

* Fix NuGet version badge

The NuGet version viewed on README badge is misleading because it was pulling data from Nuget.Core package instead of ZXing.Net

* solution for CI build

* missing project files

* AppVeyor badge

* port SHA-1: dbfd5520e9b53de492cc4ff8f8c55a440f0d6b5d

* Improve support for Macro PDF417 (#973)

* Improve support for Macro PDF417

* cleanup and move license to it's proper place

* add .editorconfig + proper indentation / add optionalFields array

* rename variables and use Arrays instead of System

* replaced length with to

* restore spaces & switch to package private

* preparing 0.16.3

* clarification how the byte array barcode reader should be used

* [ZKWeb] Add ZKWeb.System.Drawing as alternative to CoreCompat.System.Drawing. ZKWeb.System.Drawing use own namespace (System.DrawingCore) and dont override official MS libraries. Helps for multitarget (e.g. net47 and netstandard)

* ZKWeb binding: remove signing (ZKWeb self isn't signed), adding assembly to deployment

* micjahn#96: stride argument of WriteableBitmap.WritePixels()

* ZXing Magick binding:
micjahn#98: Performance of Magick bar code reader
micjahn#99: Renderer for Magick

* compatibility fix for windows ce

* cleanup solutions

* update svn tool

* updated build files

* updated deployment files

* Bindings: version increment, compatibility fixes

* signing validation reworked

* binding updated to SixLabors.ImageSharp version 1.0.0-beta0003

* solution updates

* versionnumbers

* [micjahn#117] Compatibility issue with Magick.Net 7.4.6
* updated Magick.Net dependency to 7.4.6
* added .Net Standard 2.0 build

* removed obsolete files

* micjahn#23 Strange indentation
reformatted (most of) all files to default of 4 spaces, added .editorconfig

* [micjahn#132] Class: BitmapLuminanceSource for .Net Core 2

* [micjahn#130] Upgrade the ImageSharp-Version in the ImageSharp Bindings

* [micjahn#132] Class: BitmapLuminanceSource for .Net Core 2

* [micjahn#132] Class: BitmapLuminanceSource for .Net Core 2

* [micjahn#130] Upgrade the ImageSharp-Version in the ImageSharp Bindings

* Windows Compatibility Pack Bindings: use better namespace

* correction of the code sample for COM interop

* correction of the code sample for COM interop

* micjahn#139 Using COM interop with VBA fails

* magick binding: incremented version number

* Fixing BitmapLuminanceSource class for indexed images with incorrect palette-index data; 4bpp indexed images with odd width

* refactored BitmapLuminanceSource

* [micjahn#147] Unhandled NullReferenceException when decode qr-code with GlobalHistogramBinarizer

* + image rotation fixed.

* + tab restored

* micjahn#158: The type 'Bitmap' exists in both.... error for using both OpenCvSharp3 and .ZXing.CoreCompat same on same project
OpenCV Sharp 3.x bindings doesn't contain any classes

* bindings to Eto.Forms

* switch https://www.myget.org/F/imagesharp/ to https://www.myget.org/F/sixlabors/

* bindings to unity 3d with .net standard supported

* port SHA-1: 2c2c395afa9ba8fee13249bf5d02d13e19967207

* Issue micjahn#217: copy result metadata (like EAN extension) even when return EAN-13 as UPC-A

* port SHA-1: a372dfe17508943e1b771187eabc5b7fa58414c9

* Apply checkstyle to test code too, and fix violations; minor updates from code inspections

* port SHA-1: fa0e1d755633666174e77dee26b7d29f926500a0

* Optimize buffer size (#1013)

* port SHA-1: 7a64f483fd62afb13f651af655200a6bbfefd1db

* Various small improvements from inspection, dependency updates, preparing for 3.3.3

* port SHA-1: 4d39673d67ddaac3df71e61a51429ec94f687495

* More stuff in response to static inspection

* port SHA-1: 3778715156fac37e82fb7f2c4b604e3909a42ac7

* String of zero polynomial be "0" (#1020)

* String of zero polynomial be "0"

* add test

* add more test

* modify test case

* SHA-1: 7ff131b3cc8af909aa19d02f01856e89d89dfe9a

* Move and slightly add to new GenericGFPoly tests

* port SHA-1: 15b09aeda5c3b6e6446936ff5e44215d45643749

* remove spacing from head of polynomial string (#1032)

* port SHA-1: 0cf3b9be71680f50c90a71ca26ce0d33664b0dd6

* Fix QR-code hanzi segment decoder (#1033)

* Fix QR-code hanzi segment decoder

* remove unicode character

* port SHA-1: 48bb5fd86031d70807f374be4f77e26b989b6b54

* Check if characters are digits for EAN_13, EAN_8, ITF and UPC_EAN_EXTENSION (#1039)

* Check if characters are digits

* Use regex to check if input is valid. Added tests

* Create checkNumeric method

* Remove unused locals, moved attributes to top of class.

* Simplify testcase

* Reduce repeated code

* Fixed indentation

* Fix MIXED mode table and OR bit operator

* added round trip test for micjahn#175

* port SHA-1: e1b127c13a37ca28c3708318c26e3cba40c42ac7

* fix binary shift cost heuristics (#1044)

* fix binary shift cost heuristics

* corrected some indents

* port SHA-1: 2179c52ee3e18ddc7e3fc2e9cd8237a60315ea28

* Tighten definition of what's accepted as a URI, to exclude some potentially malicious ones

* port SHA-1: a010db7fe20287a4b79382688001be7d3bc2fc27

* Explicitly specify javadoc encoding, fix a few doc warnings, update plugins again

* port SHA-1: 36f38c5beb3a782baa34f7c98386d6b910c0450a

* Many more changes from recent IJ inspections

* port SHA-1: 5a282c5e0506035f77f36b983cb1200341021c06

* Fixed duplicated assertion (#1072)

* port SHA-1: e6937d25e8364c38cfcba6c84b42c712f707789a

* Corrected exception message in UPCEWriter (#1074)

- according to EAN13Writer, both possibilities should be reflected within the message

* fixes NullRef in PDF417 decoder

* fixes some corner cases in the PDF417 high level encoder and decoder

* compatibility fixes

* Use IMagickImage instead of MagickImage, and add support for IMagickFactory to the renderer.

* added PharmaCodeReader

* port SHA-1: 653ac2a3beb11481eff82e7d5f2bab8a745f7fac

* Improve FinderPatternFinder.selectBestPatterns (#1158)

* rewrite FinderPatternFinder.selectBestPatterns

* Update to imagesharp beta0006: Changed PackFromRgba32 to FromRgba32

* [micjahn#188] PackFromRgba32 method is missing(ZXing.ImageSharp.BarcodeWriter)

* port SHA-1: c13216ce08889bdec3a158aa3161db77dda5ad54

* Rewrite DataMatrix Detector (#1080)

* rewrite datamatrix detector

* comments

* remove unused

* modify test

* fix CI errors

* port SHA-1: 71f5773d8e1cf26d558eb99f2f6a21010935b838

* Added a null check for relative points (#1096)

* port SHA-1: 58feb44536da804e8732181e7ccbce5e94ff7d28

* fix code93 extended character decoder (#1101)

* port SHA-1: b31e090239cf20793ba222d1bf3e61d9f4fb7a44

* Optimize code width calculation in Code39Writer (#1103)

Every code39 character has 9 bars containing 3 wide bars, and separated by a white bar.
(9-3)*1 + 3*2 + 1 = 13

* port SHA-1: e636498b5e5b07bcfcdf27a3461ea3b5e127e418

* Support Full-ASCII in Code93Writer (#1104)

* support extended characters in Code93Writer

* remove redundancy

* add test for convertToExtended

* thanks for review

* fix comment, use package-private for testing

* port SHA-1: 79bdb2c84e25cd3bf92310a164e853cbfdebfd8f

* Continue in codeset A when character encoded single number or FNC1-4 in Code128Writer (#1108)

* Continue in code A when character encodes FNC1-4 in Code128Writer

* FNC1 in codeset A

* Single number also can continue in codeset A

* port SHA-1: 6b3bf9ea40e904e3c9809d5ac90f0cb383afe2f7

* fix typo (#1111)

* port SHA-1: a81dda90ba8ea5047f1ac826ec3d33c0e355b520

* Small code improvements from inspections

* port SHA-1: 9617a90616e0a9b9f2af8460194c702deb79611a

* Minor updates to plugins and from code inspection

* port SHA-1: eb6bea6ed3638ce0c733ac75d5311b367c093707

* Fixing checksum error in UPC-E barcodes (#1130)

* Converting to UPC-A before checking for matching check digits

[micjahn#128] Can't create barcode... UPCEWriter CheckSum

* port SHA-1: bc645c50bb18fb3b30a3ffaa74d042ce1ada616d

* Small fixes, dep updates, removed warning about Android app, made web app params into annotations

* port SHA-1: fedfa7a16c0d53a2c00914e0f9a116d422c271bb

* Remove duplicate results when it has structured append header. (#1147)

* remove duplicate results in processStructuredAppend

* add whitespace

* remove illegal import

* port SHA-1: 653ac2a3beb11481eff82e7d5f2bab8a745f7fac

* Improve FinderPatternFinder.selectBestPatterns (#1158)

* rewrite FinderPatternFinder.selectBestPatterns

* fixed luminance calculation for opencv bindungs and demo and grayscale images (thanks Dmitry)

* port SHA-1: f1683e1f4f670a83c37f6858a7b3db70080e04ae

* Bump to 3.4.0. Require Java 8. Various code simplifications and plugin / dep updates

* port SHA-1: 2d77cec7c835e3f07a1a258d297cc7a8b917d42d

* check format param in CodaBarWriter::encode (#1173)

* port SHA-1: 723b65fe3dc65b88d26efa4c65e4217234a06ef0

* Refactor checking of write format in 1D writers

* port SHA-1: 6075d5b2f69f285657ff65b0abcc7c7885a44eed

* Minor change to enable manual selection of the QR code mask pattern (#1176)

* Minor change to enable manual selection of the QR code mask pattern via encoding hints. Manual selection of the mask pattern greatly improves performance.

* fixed style

* port SHA-1: ae6d7e55af0b62cd18b6ac775ce3b66caf889892

* findFinderPattern()[1] points the outside pixel of the finder pattern (#1179)

* port SHA-1: 4d94ac22eb8cc7b0b5ec8176aab6b40db27e8db5

* Add addition wifi: QR code test case from mailing list

* port SHA-1: 1cc5cbe961de3606287a53765e6cde3dea24660e

* Don't run Aztec test 1000 times pointlessly

* restored files

* fixed build for some older targets

* ...sometimes I doesn't understand why...

* fixed build for some older targets

* updated nuget command line client

* command script for nuspec.xsd updated

* preparing release 0.16.5

* namespaces for nuspec.xsd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants