Remove ugly chars from end with regex #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in the demo (http://micjamking.github.io/succinct/) that if you use the character count as _30_ it leaves a "," at the end. this bothered me so i made a really simple addition that matches a regex at the end and removes characters like: *,.{[(<¦¬~^ this is set as an option so the user can change, remove or whatever. if set to 'false' it wont try to remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the demo (http://micjamking.github.io/succinct/) that if you use the character count as 30 it leaves a "," at the end. this bothered me so i made a really simple addition that matches a regex at the end and removes characters like:
*,.{[(<¦¬~^
this is set as an option so the user can change, remove or whatever. if set to 'false' it wont try to remove.
Sorry about the tab/space issues.
not a lot really changed, but my IDE changed all the spacing.