Add --id flag to zk new
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skbolton
changed the title
--id flag to zk new
|
@mickael-menu new to this project and never done any go before. Would love some feedback on the direction I have gone. I am also wondering if there are other tests that I should write and where they are. Thanks! |
skbolton
commented
Mar 22, 2022
skbolton
commented
Mar 22, 2022
This allows overriding the id generation step and just use a provided value instead.
mickael-menu
approved these changes
Mar 27, 2022
There was a problem hiding this comment.
Thank you for tackling this @skbolton!
@mickael-menu new to this project and never done any go before. Would love some feedback on the direction I have gone.
It's how I would have implemented it, though I'm not a Go expert.
I am also wondering if there are other tests that I should write and where they are. Thanks!
Not for this feature. I appreciate that you spent the time to add a tesh test case!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows overriding the id generation step and just use a provided
value instead.