Mmmmulti match #268

rktjmp · 2022-11-06T03:31:07Z

Alternative to #266

update at least one docs/ file
update all zk help output
confirm copy() requirements?

internal/adapter/sqlite/note_dao.go

internal/adapter/sqlite/note_dao_test.go

internal/cli/filtering.go

internal/cli/filtering_test.go

internal/core/note_find.go

internal/core/notebook.go

tests/cmd-list-filter-match-exact.tesh

mickael-menu

Thank you for submitting this contribution and thinking of updating the docs @rktjmp! I left a few comments but nothing major.

internal/adapter/sqlite/note_dao.go

internal/adapter/sqlite/note_dao_test.go

internal/cli/filtering.go

The elapsed time test is now 14 years (now checks for N years ago) and the get-date test would fail in non UTC timezones (now checks for +NNNN TZ).

rktjmp · 2022-11-23T17:25:46Z

Thanks for taking the time to review and answer my questions! I replied to some ⬆️.

internal/adapter/handlebars/handlebars_test.go

mickael-menu

Thanks a lot for taking the time to contribute this feature and addressing the comments! 🙏 I will release a new version with it soon.

rktjmp added 5 commits November 6, 2022 14:07

Update filtering to accept multiple -m flags, with implict AND

b682965

Update NoteFindOpts for multiple match clauses

4f25192

Update (dead?) Notebook.FindMatching function

e01b321

Generate AND queries for filter.Match []string

abba103

Update tesh test's for multi-match

062b352

rktjmp commented Nov 6, 2022

View reviewed changes

rktjmp mentioned this pull request Nov 6, 2022

Add exact-word match strategy #266

Closed

rktjmp added 6 commits November 6, 2022 15:00

Remove dead comment

7740bbc

Drop superfluous copy in note_dao

c3c16a5

Adjust help doc

dcf4224

Mention multi-match in note-filtering guide

1cf117e

Update match help tesh output

191953c

Redate test output

a50582b

rktjmp marked this pull request as ready for review November 9, 2022 13:13

rktjmp added 3 commits November 10, 2022 02:14

Update LSP docs

cf02918

Document matchStrategy and deprecate matchExact in LSP docs

36fe07e

Format table

3e21193

rktjmp mentioned this pull request Nov 9, 2022

Update ZKMatch for new match string-array requirement zk-org/zk-nvim#85

Merged

mickael-menu requested changes Nov 13, 2022

View reviewed changes

rktjmp added 7 commits November 24, 2022 02:46

Remove dead code in notebook#FindMinimalNote

a4b3bf3

Add assert.Regexp test helper

a800a7e

Add regexp testStringMatch helpr to handlebars tests

ddb3827

Relax handlebars date helper tests for different timezones

5574400

The elapsed time test is now 14 years (now checks for N years ago) and the get-date test would fail in non UTC timezones (now checks for +NNNN TZ).

Adjust match help text

b1aa931

Simplify parsedFilter.Match into f.Match with spread operator

84e2fde

Update cmd-graph and cmd-list tesh tests for --match help text

edb09ff

Revert handlebars date tests to string match with local tz+offset

2923218

rktjmp commented Nov 24, 2022

View reviewed changes

internal/adapter/handlebars/handlebars_test.go Show resolved Hide resolved

Merge branch 'main' into mmmmulti-match

1ed2ea0

Update changelog

29803bc

mickael-menu approved these changes Nov 27, 2022

View reviewed changes

mickael-menu merged commit 142b636 into zk-org:main Nov 27, 2022

ingram1107 mentioned this pull request Dec 12, 2022

Doc: ZkNotes match requires a dictionary to be passed in instead of a string zk-org/zk-nvim#89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mmmmulti match #268

Mmmmulti match #268

rktjmp commented Nov 6, 2022 •

edited

Loading

mickael-menu left a comment

rktjmp commented Nov 23, 2022

mickael-menu left a comment

Mmmmulti match #268

Mmmmulti match #268

Conversation

rktjmp commented Nov 6, 2022 • edited Loading

mickael-menu left a comment

Choose a reason for hiding this comment

rktjmp commented Nov 23, 2022

mickael-menu left a comment

Choose a reason for hiding this comment

rktjmp commented Nov 6, 2022 •

edited

Loading