Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: add references support for links #58

Merged
merged 5 commits into from Jul 10, 2021

Conversation

pstuifzand
Copy link
Contributor

The LSP returns a list of references to the link that is pointed to.

@mickael-menu
Copy link
Collaborator

mickael-menu commented Jul 9, 2021

@pstuifzand Thanks, that's a useful feature!

I'd like to update the changelog and simplify a bit the code but I'm not allowed to push on your branch. Would you mind enabling write access from me? Thanks.

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Alternatively you can add this yourself in the changelog and check out the comments I'll add to the PR.

* Support for LSP references to browse the backlinks of the link under the caret (contributed by [@pstuifzand](https://github.com/mickael-menu/zk/pull/58)).

internal/adapter/lsp/server.go Outdated Show resolved Hide resolved
internal/adapter/lsp/server.go Outdated Show resolved Hide resolved
internal/adapter/lsp/server.go Outdated Show resolved Hide resolved
internal/adapter/lsp/server.go Show resolved Hide resolved
@pstuifzand
Copy link
Contributor Author

I have made the changes you requested.

Copy link
Collaborator

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@mickael-menu mickael-menu merged commit a72a2a5 into zk-org:main Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants