Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow indexing outside notebook directory #90

Merged
merged 1 commit into from Oct 19, 2021
Merged

Allow indexing outside notebook directory #90

merged 1 commit into from Oct 19, 2021

Conversation

adamreese
Copy link
Contributor

mickael-menu
mickael-menu approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This single filepath.Join() was very dubious, thanks for spotting this!

@mickael-menu
Copy link
Collaborator

@adamreese Could you apply the following patch with git apply changelog.patch.txt? This will update the changelog. If you open another PR you can check the "Allow edits from maintainer" so I can modify the changelog directly from your branch. Thanks!

changelog.patch.txt

@adamreese
Copy link
Contributor Author

@mickael-menu I applied the patch. Thanks!

@mickael-menu mickael-menu merged commit 39467a1 into zk-org:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickael-menu mickael-menu mickael-menu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zk index only works in notebook directory
2 participants
@adamreese @mickael-menu