Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two relativePosition at same position #18

Open
samroy opened this issue Jun 23, 2016 · 6 comments
Open

Two relativePosition at same position #18

samroy opened this issue Jun 23, 2016 · 6 comments

Comments

@samroy
Copy link

samroy commented Jun 23, 2016

Hello :)

Nice work here.

Maybe I found a small glitch...
The timeline will not display correctly if at least two relativePosition are the same.

example :
var relPosDate1 = new Date(2015, 02, 04);
var relPosDate2 = new Date(2015, 02, 04);
var relPosDate3 = new Date(2016, 03, 10);
var relPosDate4 = new Date(2016, 06, 10);

@mickaelr
Copy link
Owner

Hi!

Thanks & good point, I added it to my Trello :)
I'll have to think a bit on a way to display these items correctly - I'll try to work on that next week.

@mickaelr
Copy link
Owner

Did you think about something like following example?

relative_timeline_ex

@samroy
Copy link
Author

samroy commented Jun 30, 2016

It looks good :)

@samroy samroy closed this as completed Jun 30, 2016
@mickaelr
Copy link
Owner

I reopened the issue as I didn't do the dev yet, it was just a mockup :)

@mickaelr mickaelr reopened this Jun 30, 2016
@mickaelr
Copy link
Owner

mickaelr commented Jul 6, 2016

I just pushed & updated the demo page. It's only a quick step into it but you can check and give me your feedback / ideas for the following!
Thx in advance!

@kyan001
Copy link

kyan001 commented Feb 4, 2017

when two relativePosition Items have the same label (in my case it's the date), it's better to show it only once.

for example: show "2017-02-01" instead of "2017-02-01 | 2017-02-01".

my work around is making ".timeline-me-label .timeline-me-same-position" hidden.

btw, in my opinion, same position border looks better if "border: 1px solid silver".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants