Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Moose role name #84

Merged
merged 1 commit into from Feb 1, 2019
Merged

Conversation

mikkoi
Copy link
Contributor

@mikkoi mikkoi commented Feb 1, 2019

Error when tested:

PONAPI/Server $ PERL5LIB="${PERL5LIB}:$(pwd)/../Tools/lib" prove -lv xt/001-server-with-client.t
xt/001-server-with-client.t .. You can only consume roles, PONAPI::Builder::Role::HasPagination is not a Moose role at /home/users/mikkoi/.anyenv/envs/plenv/versions/5.14.2-for-dev/lib/perl5/site_perl/5.14.2/x86_64-linux/Moose/Exporter.pm line 419
Moose::with('PONAPI::Builder::Role::HasPagination')
called at xt/001-server-with-client.t line 482
main::BEGIN at xt/001-server-with-client.t line 690
eval {...} at xt/001-server-with-client.t line 690
BEGIN failed--compilation aborted at xt/001-server-with-client.t line 690.

Signed-off-by: Mikko Johannes Koivunalho mikko.koivunalho@inoviagroup.se

Error when tested:

PONAPI/Server $ PERL5LIB="${PERL5LIB}:$(pwd)/../Tools/lib" prove -lv
xt/001-server-with-client.t
xt/001-server-with-client.t .. You can only consume roles,
        PONAPI::Builder::Role::HasPagination is not a Moose role at /home/users/mikkoi/.anyenv/envs/plenv/versions/5.14.2-for-dev/lib/perl5/site_perl/5.14.2/x86_64-linux/Moose/Exporter.pm line 419
        Moose::with('PONAPI::Builder::Role::HasPagination')
        called at xt/001-server-with-client.t line 482
        main::BEGIN at xt/001-server-with-client.t line 690
        eval {...} at xt/001-server-with-client.t line 690
BEGIN failed--compilation aborted at xt/001-server-with-client.t line 690.

Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@inoviagroup.se>
@mickeyn
Copy link
Owner

mickeyn commented Feb 1, 2019

This one is odd, as document building was extracted into its own package (I guess we didn't encounter the error since we had the old version with the Builder directory installed on our machine and it's not removed when installing a newer version).

I can accept the change as it's just making a use of _hash_to_uri_query for this test only, but should probably be reviewed and changed later on.

@mickeyn mickeyn merged commit cdc50f8 into mickeyn:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants