Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combobulate-splice-up throws an error #37

Closed
DamienCassou opened this issue May 7, 2023 · 2 comments
Closed

combobulate-splice-up throws an error #37

DamienCassou opened this issue May 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DamienCassou
Copy link
Contributor

Given the code below in js-ts-mode:

function f() {
    console.log("foo");
    console.log("bar");
}

If point is the the beginning of console.log("bar"); and I ask for combobulate-splice-up, I get an error message:

combobulate-procedure-start: There are no valid procedures that apply to ‘Expression Statement’.

I would expect the result to be:

function f() {
    console.log("bar");
}
@mickeynp
Copy link
Owner

mickeynp commented May 8, 2023

Hm, if anything it should take it out of the function into the main body of the file. However, the splice functions do not work everywhere; it's an active area of research of mine to build something that can work generically in most places. There's more work to do here unfortunately.

@mickeynp mickeynp added the bug Something isn't working label May 8, 2023
@mickeynp mickeynp closed this as completed Mar 1, 2024
@mickeynp
Copy link
Owner

mickeynp commented Mar 1, 2024

Fixed, as the entire splice system is revamped and far more advanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants