New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only the right side of wide PragmataPro ligatures are displaying #33
Comments
ligature.el just communicates with the underlying composition table mechanism in Emacs so it's possible the issue is in Emacs. Does the ligature display correctly if you only configure your ligature settings with the broken one? |
@mickeynp Thank you for your response. Digging around it may be a problem with enabling Cairo support so I did submit an Emacs bug report with the steps:
Although since your package allows the first few words to display properly, I wondered if you could provide any workaround. I attempted your experiment of configuring only with the broken ligatures:
The result is the same. |
If it's broken with even a single ligature then it's unlikely the package can do anything. You could try compiling Emacs with/without Cairo to see if it makes a difference? It does sound like a strange issue though. Alternatively you can have a look at |
Could you show the output of C-u C-x = at the beginning of the "[FIXME]" ligature (not shown by PUA char, but with ligature.el) for each configuration? |
I'm seeing the same thing, where the right half of the long PragmataPro ligatures are getting clipped, but show up properly when building without Cairo. C-u C-x = with Cairo:
C-u C-x = without Cairo:
|
I recommend you |
Sorry for the late reply. At least there is some problem with metrics calculation for the shaped glyphs. Could someone check if the following change to the emacs-28 branch makes some difference when linked with HarfBuzz 5.1.0? |
@Game4Move78 Does your list above includes all the ligatures from this gist by Fabrizio Schiavi here: https://gist.github.com/fabrizioschiavi/f40a54c8211833c75c81ec82f0c0dd1c ? |
On the left is buffer visiting my init file and right is buffer visiting a Python file.
Settings are
(ligature-set-ligatures 'prog-mode '("[ERROR]" "[DEBUG]" "[INFO]" "[WARN]" "[WARNING]" "[ERR]" "[FATAL]" "[TRACE]" "[FIXME]" "[TODO]" "[BUG]" "[NOTE]" "[HACK]" "[MARK]" "# ERROR" "# DEBUG" "# INFO" "# WARN" "# WARNING" "# ERR" "# FATAL" "# TRACE" "# FIXME" "# TODO" "# BUG" "# NOTE" "# HACK" "# MARK" "// ERROR" "// DEBUG" "// INFO" "// WARN" "// WARNING" "// ERR" "// FATAL" "// TRACE" "// FIXME" "// TODO" "// BUG" "// NOTE" "// HACK" "// MARK" "!!" "!=" "!==" "!!!" "!≡" "!≡≡" "!>" "!=<" "#(" "#_" "#{" "#?" "#>" "##" "#_(" "%=" "%>" "%>%" "%<%" "&%" "&&" "&*" "&+" "&-" "&/" "&=" "&&&" "&>" "$>" "***" "*=" "*/" "*>" "++" "+++" "+=" "+>" "++=" "--" "-<" "-<<" "-=" "->" "->>" "---" "-->" "-+-" "-\\/" "-|>" "-<|" ".." "..." "..<" ".>" ".~" ".=" "/*" "//" "/>" "/=" "/==" "///" "/**" ":::" "::" ":=" ":≡" ":>" ":=>" ":(" ":-(" ":)" ":-)" ":/" ":\\" ":3" ":D" ":P" ":>:" ":<:" "<$>" "<*" "<*>" "<+>" "<-" "<<" "<<<" "<<=" "<=" "<=>" "<>" "<|>" "<<-" "<|" "<=<" "<~" "<~~" "<<~" "<$" "<+" "<!>" "<@>" "<#>" "<%>" "<^>" "<&>" "<?>" "<.>" "</>" "<\\>" "<\">" "<:>" "<~>" "<**>" "<<^" "<!" "<@" "<#" "<%" "<^" "<&" "<?" "<." "</" "<\\" "<\"" "<:" "<->" "<!--" "<--" "<~<" "<==>" "<|-" "<<|" "<-<" "<-->" "<<==" "<==" "=<<" "==" "===" "==>" "=>" "=~" "=>>" "=/=" "=~=" "==>>" "≡≡" "≡≡≡" "≡:≡" ">-" ">=" ">>" ">>-" ">>=" ">>>" ">=>" ">>^" ">>|" ">!=" ">->" "??" "?~" "?=" "?>" "???" "?." "^=" "^." "^?" "^.." "^<<" "^>>" "^>" "\\\\" "\\>" "\\/-" "@>" "|=" "||" "|>" "|||" "|+|" "|->" "|-->" "|=>" "|==>" "|>-" "|<<" "||>" "|>>" "|-" "||-" "~=" "~>" "~~>" "~>>" "[[" "]]" "\">" "_|_"))
Some word ligatures are not displaying at all. Some are clipped.
A similar issue occurs when I enable PragmataPro ligatures via a different package, but while that enables all ligatures to display, it results in all of them being clipped to the last few columns. Your package allows the first few words to display properly.
Spacemacs v.0.3 with GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-09
The text was updated successfully, but these errors were encountered: