Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPreview defaults to true #4

Closed
jessecascio opened this issue Jun 23, 2016 · 2 comments
Closed

isPreview defaults to true #4

jessecascio opened this issue Jun 23, 2016 · 2 comments

Comments

@jessecascio
Copy link

jessecascio commented Jun 23, 2016

Theres logic in there that overrides the default Apple News API behaviour with no documentation that this happens. As outlined in the Apple docs on isPreview:

Default value: True if your channel has not yet been approved to publish articles in Apple News Format; False if your channel has been approved.

But this module explicitly sets it to true if not defined.

@iefserge
Copy link
Contributor

@jessecascio Yep, I think this way it's more predictable and requires explicit permission to publish public articles.

@ryanscottaudio
Copy link
Contributor

Added isPreview = true to readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants