Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route headers not properly reversed from RR set when RR URIs comma-separated #11

Closed
abalashov opened this issue Jul 4, 2022 · 2 comments

Comments

@abalashov
Copy link
Contributor

When using the -invite flow, a 200 OK is received by the sipexer UA with two RR hops:

Record-Route: <sip:GW_2:5060;lr=on;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;vsf=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AA-;dlgcor=ccf1.7e73;proxy_media=yes>
Record-Route: <sip:GW_1:5060;lr;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;dlgcor=ccf.8be1;fromcor=ejFwbUZxUmpUUFNBejFwbUZxU
UUFNBejFwbUZxUmpUUFM-;proxy_media=yes>

This is properly reversed in the order of the Route headers constructed in the e2e ACK / subsequent in-dialog messages:

Route: <sip:GW_1:5060;lr;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;dlgcor=ccf.8be1;fromcor=ejFwbUZxUmpUUFNBejFwbUZxUmp
FNBejFwbUZxUmpUUFM-;proxy_media=yes>
Route: <sip:GW_2:5060;lr=on;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;vsf=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
-;dlgcor=ccf1.7e73;proxy_media=yes>

However, if the RR set returned is compacted into a single value...

Record-Route: <sip:GW_2:5060;lr=on;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;vsf=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AA-;dlgcor=ccf1.7e73;proxy_media=yes>, <sip:GW_1:5060;lr;ftag=37ff691d-7bf2-446b-abaa-9c09fe12deb1;dlgcor=ccf.8be1;fromcor=ejFwbUZxUmpUUFNBejFwbUZxU
UUFNBejFwbUZxUmpUUFM-;proxy_media=yes>

Then this order is imitated, rather than reversed, in the subsequent Route construction.

@abalashov
Copy link
Contributor Author

It was pointed out to me that the ABNF spec for record-route technically consists of a name-addr, which could have a comma in it. I choose not to address it in this PR at this time. 😀

@miconda
Copy link
Owner

miconda commented Jul 4, 2022

Thanks, PR merged!

@miconda miconda closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants