Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Server Sent Events (SSE) #73

Open
Tracked by #34
linknum23 opened this issue Feb 22, 2021 · 5 comments
Open
Tracked by #34

Add Server Sent Events (SSE) #73

linknum23 opened this issue Feb 22, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@linknum23
Copy link
Contributor

SSE will allow notification on change events to be sent when the system state is modified. The idea is that a client registers to receive types of change events and is alerted when they happen. This will be useful for enhancing our webapp and should be useful for many different types of home automation integration.

@linknum23 linknum23 self-assigned this Feb 22, 2021
@linknum23 linknum23 added the enhancement New feature or request label Feb 26, 2021
@jberry
Copy link

jberry commented Mar 1, 2021

We have a discussion going on (#77) talking about implementing some keypads. How solid is the SSE decision that that's the route this will probably be going?
Obviously anything can change/this isn't a given feature until it's delivered, but is SSE a solid-enough decision on the publish/subscribe system to use that it wouldn't be a waste of time for me to start learning/messing with it? (I've always been an MQTT user)

@linknum23
Copy link
Contributor Author

@jberry We have not invested any time in testing it yet, my only concern with it is whether or not the volume controls will feel really responsive with SSE, if they don't we might have to use websockets. This is something we should know in the next couple of weeks when we do a second pass on the webapp.

@linknum23 linknum23 added this to To do in AmpliPi Mar 3, 2021
@linknum23
Copy link
Contributor Author

We are prototyping SSE by using it for updates, it's been pretty easy to work with so far.

@linknum23
Copy link
Contributor Author

Something to think about, we will probably need to add some sort of granular change support on the python side of things to avoid sending the full JSON state every time something is updated.

@linknum23 linknum23 moved this from To do to In progress in AmpliPi Jun 1, 2021
@Lohrer Lohrer moved this from In progress to To do in AmpliPi Nov 17, 2021
@linknum23 linknum23 moved this from To do to In progress in AmpliPi Dec 28, 2021
@linknum23 linknum23 moved this from In progress to Done in AmpliPi May 4, 2022
@linknum23 linknum23 moved this from Done to In progress in AmpliPi May 4, 2022
@linknum23 linknum23 mentioned this issue Jun 1, 2022
35 tasks
@linknum23
Copy link
Contributor Author

Some initial work was done in #254 on branch https://github.com/micro-nova/AmpliPi/tree/add_sse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
AmpliPi
In progress
Development

No branches or pull requests

2 participants