Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confused handler when rpc client catch serve rerror #87

Closed
btfak opened this issue May 15, 2016 · 7 comments
Closed

confused handler when rpc client catch serve rerror #87

btfak opened this issue May 15, 2016 · 7 comments

Comments

@btfak
Copy link

btfak commented May 15, 2016

we know it is common that server return an error, but blacklist of default selector limit 3 error, then we have no services available. can we turn off blacklist?

@asim
Copy link
Member

asim commented May 15, 2016

The selector is pluggable. You can write a new selector that suits your requirements. We could potentially provide one that doesn't blacklist. But the fact that the call fails 3 times implies there's an issue, hence blacklisting the node. Only that specific node is blacklisted. So if you're only running one instance of a service, yes it's going to return no service available. Why is it throwing an error? Can you run more instances of the service?

@btfak
Copy link
Author

btfak commented May 16, 2016

I guess the key is

what is the best way to throwing error?

for example:invalid request params and so on,they will return error,but not reason to block that specific node. People will benchmark wrong request and make all node not available

@btfak
Copy link
Author

btfak commented May 16, 2016

I have use my own selector,problem solved.

@asim
Copy link
Member

asim commented May 16, 2016

great

@asim asim closed this as completed May 16, 2016
@asim
Copy link
Member

asim commented May 16, 2016

Let us know if you open source it. Would be great to see what it looks like.

@btfak
Copy link
Author

btfak commented May 16, 2016

ok,my team use micro on a e-commerce project, we will open source some plugins when code stable.
your great job help us reduce much work,thanks

@asim
Copy link
Member

asim commented May 16, 2016

Cool. Feel free to add your company to the Users list https://github.com/micro/micro/wiki/Users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants