Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify peak picking parameters to call by relative abundance (not absolute value) #48

Closed
Tracked by #28
kheal opened this issue Apr 26, 2024 · 1 comment
Closed
Tracked by #28
Assignees

Comments

@kheal
Copy link
Collaborator

kheal commented Apr 26, 2024

Will change in lcmsrefactor branch.

Current peak picking parameters for LCMSBase class for minimum height and persistence are set as absolute values. In order to better parameterize these settings and follow conventions in CoreMS, we should change this to use a parameter like relative abundance for setting minimums.

As currently implemented, that is how we set our values, so functionally it will not change, just the parameter names will change.

@kheal kheal self-assigned this Apr 26, 2024
@kheal
Copy link
Collaborator Author

kheal commented Apr 29, 2024

@kheal kheal closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant