Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

add attributes to study model #301

Closed
dehays opened this issue Mar 22, 2021 · 10 comments
Closed

add attributes to study model #301

dehays opened this issue Mar 22, 2021 · 10 comments

Comments

@dehays
Copy link
Contributor

dehays commented Mar 22, 2021

https://github.com/microbiomedata/nmdc-server/blob/master/nmdc_server/ingest/study_additional.json

A number of study related fields are displayed in the portal UI that are not currently in the schema. In addition to deciding what must be added, we need to consider the process by which these values are included

@wdduncan wdduncan added the enhancement New feature or request label Mar 31, 2021
@dehays
Copy link
Contributor Author

dehays commented Mar 31, 2021

To clarify - this issue is about the attributes getting added (PI web sites, publications, PI image) downstream in the portal UI. Issue #150 is about adding a relationship between biosamples and studies

@dwinston
Copy link
Contributor

dwinston commented Apr 1, 2021

connects to e.g. #314

@dwinston
Copy link
Contributor

dwinston commented Apr 1, 2021

@jeffbaumes duplicated by #315?

@jeffbaumes
Copy link

I believe a conversation about what is in this JSON between @jbeezley and @wdduncan could start to address this.

@ssarrafan ssarrafan added this to the Sprint 1 milestone Apr 12, 2021
@wdduncan wdduncan assigned wdduncan, jbeezley and dwinston and unassigned jbeezley and wdduncan Apr 16, 2021
@wdduncan
Copy link
Contributor

@ssarrafan can you move this to the next sprint?

@ssarrafan ssarrafan removed this from To do in NMDC April 2021 Sprint Apr 16, 2021
@ssarrafan ssarrafan modified the milestones: Sprint 1, Sprint 2 Apr 16, 2021
@ssarrafan
Copy link

@ssarrafan can you move this to the next sprint?

It's been moved to the May sprint.

@kfagnan
Copy link
Contributor

kfagnan commented May 5, 2021

Was the suggestion at today's TechSync to divide this ticket up?

It would be nice if there were default values or placeholders for fields that we know we want to show up on the portal - even if we don't have the data. The route in for the data definitely needs to be sorted out - as David pointed out.

It would also be nice to give the users a way to upload this content, but that can be down the road.

@wdduncan wdduncan removed this from To do in NMDC May 2021 Sprint May 29, 2021
@wdduncan wdduncan added this to To do in NMDC June 2021 Sprint via automation May 29, 2021
@ssarrafan
Copy link

Removing Jon and Donny per discussion with Kjiersten. @wdduncan let me know if this shouldn't be assigned to you or if you don't have time to work on it.

@ssarrafan ssarrafan removed this from the Sprint 2 milestone Jun 4, 2021
@ssarrafan ssarrafan added this to the Sprint 3 milestone Jun 4, 2021
@ssarrafan
Copy link

@wdduncan is this ticket a duplicate of #51 ? Can this one be closed?

@wdduncan
Copy link
Contributor

Hi @ssarrafan This looks like a duplicate of microbiomedata/nmdc-schema#51.
So, I'll close this ticket. Reopen if needed.

NMDC June 2021 Sprint automation moved this from To do to Done Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

7 participants