Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear data log when main.py is opened for write #48

Open
microbit-matt-hillsdon opened this issue Sep 6, 2022 · 1 comment
Open

Clear data log when main.py is opened for write #48

microbit-matt-hillsdon opened this issue Sep 6, 2022 · 1 comment

Comments

@microbit-matt-hillsdon
Copy link
Contributor

microbit-matt-hillsdon commented Sep 6, 2022

microbit-foundation/micropython-microbit-v2@6ade36b introduced a change that clears the data log on opening main.py for write. We have our own main.py and our own file system so don't get that in the simulator for free.

However, we already clear the log on flash, so I think this would just catch self-rewriting programs in the simulator context. For that reason I don't think it's worth doing right now as part of #47 as we're pressed for time.

@microbit-carlos
Copy link
Collaborator

I agree, if every time the "play" button is pressed it clears the log there is no need to do much else right now.

After launch we can look into adding the hook for self-modifying programmes, but it's safe to assume the impact will be almost insignificant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants