Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a typo in atca_tests_gendig.c? #49

Closed
habebit opened this issue Jan 24, 2019 · 2 comments
Closed

Is there a typo in atca_tests_gendig.c? #49

habebit opened this issue Jan 24, 2019 · 2 comments

Comments

@habebit
Copy link

habebit commented Jan 24, 2019

Hi there, thanks for your work. Is there a typo? I thought the configuration zone should be locked, before you can generate a private key and a corresponding public key. I think it should be called ...if data zone is locked instead of ...

* test will generate a private key if data zone is unlocked and return a public key

@bryan-hunt
Copy link
Contributor

The line directly above the one listed says the configuration zone should be locked:

/** \brief this test assumes a specific configuration and locked config zone
 * test will generate a private key if data zone is unlocked and return a public key
 * test will generate a public key based on the private key if data zone is locked
 */

Genkey can also be run when the data zone is unlocked (and would be a necessity when the configuration doesn't allow a genkey on a slot after the device is provisioned)

@habebit
Copy link
Author

habebit commented Jan 24, 2019

Sorry, you are absolutly right. My mistake! Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants