Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test to UploadArtifactController #1150

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Apr 23, 2024

Considerations

Important

We need to be careful changing the specification on samples, because can break those tests.

Description

  • Rename AMQPMessageConsumptionTaskITest to AMQPMessageConsumptionTaskIT
  • Add integration test to ÙploadArtifactController`

Related issue(s)

#1128

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

private ServiceService serviceService;

public UploadArtifactController(ServiceService serviceService) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autowired import should be removed as well on L27. I'll do that after merge.

@lbroudoux lbroudoux added this to the 1.9.1 milestone Apr 24, 2024
@lbroudoux lbroudoux merged commit 7f475d0 into microcks:1.9.x Apr 24, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants