New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/set doesn't work, when device name isn't same as device id #1

Closed

rozpuszczalny opened this issue Dec 5, 2018 · 0 comments

Contributor

rozpuszczalny commented Dec 5, 2018

Hi,
Thanks for great work! I found that settable doesn't work, when device name is not same as device id.

homie-device/lib/homieDevice.js

Line 211 in ea09c1b

if (parts[1] == t.name && parts[4] == 'set') {

I'm also providing pull request with test, to show the problem, and solution to this problem.
Best regards

rozpuszczalny mentioned this issue

Check topic part against device_id, not device name #2

Merged

lorenwest closed this as completed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment