Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classic microformats support much stricter #32

Closed
barnabywalters opened this issue Oct 17, 2013 · 3 comments
Closed

Make classic microformats support much stricter #32

barnabywalters opened this issue Oct 17, 2013 · 3 comments

Comments

@barnabywalters
Copy link
Collaborator

If any mf2 classnames are found in a document, don’t convert any classic mf classnames

E.G. currently parsing this URL with classic support turned on produces bad results due to classic mf classnames being on different elements to mf2 classnames — with stricter checking this would not be a problem.

@aaronpk
Copy link
Member

aaronpk commented Oct 20, 2013

Here is another example of overly aggressive parsing:

http://pdx.esri.com/blog/2013/10/17/introducting-mapattack/

The "description" values should not be in the parsed result.

@aaronpk
Copy link
Member

aaronpk commented Oct 20, 2013

Because of the overly aggressive parsing, I propose removing the default of "parse legacy microformats" for now.

@barnabywalters
Copy link
Collaborator Author

Resolved in v0.2.0 with improved (more spec-compliant) classic mf support. I’m leaving convert classic on by default to help root out bad markup, it shouldn’t be so much of a problem now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants