Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goto: Rename disableAnimations into animations #127

Closed
Kikobeats opened this issue Jan 9, 2020 · 2 comments · Fixed by #130
Closed

goto: Rename disableAnimations into animations #127

Kikobeats opened this issue Jan 9, 2020 · 2 comments · Fixed by #130

Comments

@Kikobeats
Copy link
Member

No description provided.

@Kikobeats Kikobeats changed the title Rename disableAnimations into animations goto: Rename disableAnimations into animations Jan 9, 2020
@adityawankhede5
Copy link
Contributor

I have found in total 13 exact matches for disableAnimations:
So should I rename all the matches or only those present /packages/goto/ directory.

  1. CHANGELOG.md:294:* ensure to call disableAnimations after goto (d73c964)
  2. packages/browserless/src/index.js:99: html: evaluate(page => page.content(), { disableAnimations: false }),
  3. packages/browserless/src/index.js:104: disableAnimations: false
  4. packages/goto/CHANGELOG.md:129:* ensure to call disableAnimations after goto (d73c964)
  5. packages/goto/src/index.js:59: { url, media, adblock = true, headers = {}, waitFor = 0, disableAnimations = true, disableJavaScript = false,
    ...args }
  6. packages/goto/src/index.js:101: if (disableAnimations) {
  7. packages/goto/src/index.js:102: debug({ disableAnimations })
  8. README.md:137: disableAnimations: false
  9. README.md:163: disableAnimations: false
  10. README.md:189: disableAnimations: true,
  11. README.md:260: disableAnimations: true,
  12. README.md:466: disableAnimations: false
  13. README.md:510:##### disableAnimations

@Kikobeats
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants