New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: unify tldts #596

Merged

Kikobeats merged 1 commit into master from tldts

Nov 11, 2022

Member

Kikobeats commented Nov 11, 2022 •

edited

The goal is to avoid reparse values already computed previously.

This PR unifies tldts inside metascraper helper, wrapped by lodash.memoize.

A little benchmark performed inside tests:

first method call: 0.30225ms
successive calls: 0.016458ms

Kikobeats force-pushed the tldts branch from 3bc420f to 0955f16 Compare

November 11, 2022 22:47


          perf: unify tldts

43422a9

Kikobeats force-pushed the tldts branch from 0955f16 to 43422a9 Compare

November 11, 2022 22:51

Collaborator

coveralls commented Nov 11, 2022

Coverage increased (+0.002%) to 98.286% when pulling 43422a9 on tldts into 24f318a on master.

Kikobeats merged commit 00a0633 into master

Kikobeats deleted the tldts branch

November 11, 2022 22:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment