Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logo): use google logo endpoint #599

Merged
merged 1 commit into from Nov 14, 2022
Merged

feat(logo): use google logo endpoint #599

merged 1 commit into from Nov 14, 2022

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Nov 14, 2022

The Google logo endpoint is an internal API, but it's well-known on the internet.

After run a logo benchmark, it looks like it's worth it to add for the very last to check before returning undefined.

@Kikobeats Kikobeats force-pushed the logo/google branch 6 times, most recently from 9fb6a71 to 8087db6 Compare November 14, 2022 20:43
@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2022

Coverage Status

Coverage decreased (-0.03%) to 98.16% when pulling 784a580 on logo/google into d783e68 on master.

@Kikobeats Kikobeats changed the title refactor(logo): use google logo endpoint feat(logo): use google logo endpoint Nov 14, 2022
@Kikobeats Kikobeats merged commit f68f93d into master Nov 14, 2022
@Kikobeats Kikobeats deleted the logo/google branch November 14, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants