Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetchData parameter #223

Merged
merged 4 commits into from
May 13, 2020
Merged

feat: add fetchData parameter #223

merged 4 commits into from
May 13, 2020

Conversation

Kikobeats
Copy link
Member

closes #187

@Kikobeats Kikobeats requested a review from breadadams May 10, 2020 21:56
Copy link
Member

@breadadams breadadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think you'll need to update the storybook examples too @Kikobeats

storybook is using a removed jest API

related: storybookjs/storybook#10631
@Kikobeats Kikobeats merged commit 8dcdea4 into master May 13, 2020
@Kikobeats Kikobeats deleted the fetch-data branch May 13, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate fetch from setData
2 participants