Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infinite loading #298

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: infinite loading #298

merged 1 commit into from
Mar 22, 2023

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Mar 22, 2023 •
edited

CleanShot 2023-03-22 at 09 55 03@2x

The changes introduced in #296 are causing the component doesn't change the state, it looks like inifite loading.

How to reproduce

  1. clone https://github.com/microlinkhq/www
  2. install the deps (pnpm install)
  3. link your local @microlink/sdk@5.5.13 with the site
  4. run the site (npm run dev) and visit a route that uses the component (.e.g, http://localhost:8000/docs/sdk/parameters/url)

@vercel
Copy link

vercel bot commented Mar 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sdk-hover-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 8:52AM (UTC)
sdk-hover-vanilla 🔄 Building (Inspect) Mar 22, 2023 at 8:52AM (UTC)
sdk-react ✅ Ready (Inspect) Visit Preview Mar 22, 2023 at 8:52AM (UTC)
sdk-vanilla 🔄 Building (Inspect) Mar 22, 2023 at 8:52AM (UTC)

@Kikobeats Kikobeats merged commit 159f1d5 into master Mar 22, 2023
@Kikobeats Kikobeats deleted the linter branch March 22, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Kikobeats