Does not handle + properly

[UltCombo]

Test case:

micromatch.isMatch('coffee+/src/glimini.js', 'coffee+/src/**');

Actual: false
Expected: true

Tested with micromatch@2.2.0.

[jonschlinkert]

thanks for reporting. I'll look into it asap

[jonschlinkert]

this should be a pretty simple fix. basically + is recognized as a regex character, so it's trying to match one or more e characters, but we need it to match a literal + instead. I'll get a patch pushed up.

[UltCombo]

That makes sense. Though, as far as I can see, the + character is properly listed in the chars.escapeRegex object. I'm not familiar enough with this code base to find what is going wrong.

[jonschlinkert]

no worries, I'll track it down. I'm pretty sure I know where it is. that character is used in both extglobs and brace expansion - but, neither would be causing this issue since they match fairly specific patterns.

if you have any more ideas for test cases I can add to the unit tests, that would be great.

[jonschlinkert]

@UltCombo could you try your test case against this patch and see if that works for you?

[UltCombo]

Oh nice, I'll try it tonight. 😄

[UltCombo]

Works great, thanks for the quick fix! 😸

[jonschlinkert]

great! no problem of course, I appreciate you creating an issue. I'll get a patch pushed up shortly