Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynatrace limits uploads to 15k #1104

Closed
pjfanning opened this issue Dec 27, 2018 · 6 comments
Closed

dynatrace limits uploads to 15k #1104

pjfanning opened this issue Dec 27, 2018 · 6 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Dec 27, 2018

I suggest that we can support a dynatrace.maxMessageSize property.

kontainers/micrometer-registry-dynatrace@48e27c7 has an implementation where if the limit is reached, the upload data is split over multiple messages.

@jkschneider
Copy link
Contributor

Does dynatrace blow up if the 15k limit is exceeded?

@pjfanning
Copy link
Contributor Author

pjfanning commented Dec 31, 2018

Dynatrace rejects the message if it exceeds 15k with a HTTP 413 Payload Too Large response.

{"code":413,"message":"Entity must not be larger than 15360 bytes"}

@jkschneider
Copy link
Contributor

Good to know. Is there any value then in making the max size configurable?

@pjfanning
Copy link
Contributor Author

In kontainers/micrometer-registry-dynatrace@48e27c7 - I split the message into mutiple messages so that none exceeds the maxMessageSize.

@jkschneider
Copy link
Contributor

@pjfanning Yep, implementation makes sense. Should we make the max size a config option though or hard code that? My biases lean me away from a config option simply so we aren't committed to that from an API surface area perspective. That is, unless there is some immediate reason why configurability is desirable.

@pjfanning
Copy link
Contributor Author

I guess we could hardcode 15k. I can put together an MR in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants