Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer is emitting 0 values for @Timed annotated methods #1714

Open
stefluhh opened this issue Nov 20, 2019 · 1 comment
Open

Micrometer is emitting 0 values for @Timed annotated methods #1714

stefluhh opened this issue Nov 20, 2019 · 1 comment
Labels
enhancement A general enhancement registry: influx An InfluxDB Registry related issue waiting for feedback We need additional information before we can continue
Milestone

Comments

@stefluhh
Copy link

Hello,

I started introducing micrometer and use the @Timed annotation to keep track on my Controllers' REST endpoints and I am having trouble with getting too many orphaned data in InfluxDb. I doubt that it has something to do with InfluxDb or the @Timed annotation, but I think this might be a missing feature in general.

I was reading a bit about this already and while some people say my step-ratio of 15s should be tweaked according to my expected traffic, I would argue this does not really help out, because even high traffic applications have @Timed annotated methods in the code that are called less often than other methods.

Let's imagine a Onlineshop checkout application having a REST method for creating baskets and a REST method for retreiving the remaining giftcard amount of giftcard XYZ. For sure in the night there are still a lot of baskets created, but only every couple of minutes there is 1 call for evaluation of a giftcard balance. For this reason my InfluxDb is filled with 0's unnecessarily and I am looking for a way of suppressing emitting of 0 values.

Did someone find a way of doing so?

Thanks in advance.

@shakuzen shakuzen added registry: influx An InfluxDB Registry related issue enhancement A general enhancement labels Dec 5, 2019
@shakuzen shakuzen added this to the 1.x milestone Dec 5, 2019
@shakuzen
Copy link
Member

shakuzen commented Dec 5, 2019

If I'm understanding the enhancement request, you would like a configuration option for metrics that have not been updated to not be sent to Influx, correct?

I am having trouble with getting too many orphaned data in InfluxDb.

I am not an InfluxDB expert, so I don't understand the problem that is being caused. Could you elaborate? Is it just a matter of taking up space with metrics that are not useful (because they haven't been updated), or something else?
One thing to consider is that when not sending metrics that haven't changed, it can be easy to mistake this with the metric not being registered at all after some time.

@marcingrzejszczak marcingrzejszczak added the waiting for feedback We need additional information before we can continue label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: influx An InfluxDB Registry related issue waiting for feedback We need additional information before we can continue
Projects
None yet
Development

No branches or pull requests

3 participants