Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphiteMeterRegistry reports 3 times on close() #2164

Closed
shakuzen opened this issue Jun 22, 2020 · 0 comments
Closed

GraphiteMeterRegistry reports 3 times on close() #2164

shakuzen opened this issue Jun 22, 2020 · 0 comments
Labels
bug A general bug registry: graphite A Graphite Registry related issue release notes Noteworthy change to call out in the release notes
Milestone
1.6.0

Comments

@shakuzen
Copy link
Member

shakuzen commented Jun 22, 2020 •
edited

See #2156. For Micrometer 1.6.0, we will remove the redundant (since Dropwizard metrics-core 4.1.8) call to report when closing the GraphiteMeterRegistry. In order to retain the final publish on close behavior, users should be using at least version 4.1.8 of metrics-core. Earlier versions of metrics-core will result in not having the final publish on close behavior anymore since Micrometer 1.6.0.
@shakuzen shakuzen added bug A general bug registry: graphite A Graphite Registry related issue release notes Noteworthy change to call out in the release notes labels Jun 22, 2020
@shakuzen shakuzen added this to the 1.6.0 milestone Jun 22, 2020
This was referenced Jun 26, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug registry: graphite A Graphite Registry related issue release notes Noteworthy change to call out in the release notes
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@shakuzen