Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Relic Insights has been deprecated #3033

Open
ebullient opened this issue Feb 18, 2022 · 10 comments
Open

New Relic Insights has been deprecated #3033

ebullient opened this issue Feb 18, 2022 · 10 comments
Labels
enhancement A general enhancement feedback-provided registry: new relic A New Relic Registry related issue
Milestone

Comments

@ebullient
Copy link
Contributor

I tested the lib for new relic and found out that it connects to New Relic Insights which is deprecated at this moment
docs

Additional context
Originally raised against the Micrometer support in Quarkiverse

We had conversations with @breedx-nr and @jkwatson about the forked New Relic MeterRegistry: https://github.com/newrelic/micrometer-registry-newrelic, but I'm not sure if it is dead or alive (and both have left New Relic in the interim).

@ebullient ebullient added the enhancement A general enhancement label Feb 18, 2022
@shakuzen
Copy link
Member

Thanks for bringing the deprecation to our attention. There have been discussions in the past about converging towards one registry implementation for New Relic support going forward. Related discussions: micrometer-metrics/micrometer-docs#137 and newrelic/micrometer-registry-newrelic#46. Since New Relic has deprecated Insights, I think deprecating the registry here and directing users to the New Relic maintained https://github.com/newrelic/micrometer-registry-newrelic is probably the best path forward. There were concerns from a user about transitioning from Insights to New Relic One here. @neiljpowell have you had a chance to try out the New Relic maintained registry and what a transition from the registry hosted here to that one looks like? Is there anything we can do in either implementation to help users migrate more easily?

@shakuzen shakuzen added the registry: new relic A New Relic Registry related issue label Feb 22, 2022
@shakuzen shakuzen added this to the 1.9 backlog milestone Feb 22, 2022
@shakuzen shakuzen changed the title Update New Relic Insights to New Relic One New Relic Insights has been deprecated Feb 22, 2022
@wilkinsona
Copy link
Contributor

I think deprecating the registry here and directing users to the New Relic maintained [registry]

Given the breaking API changes that are coming in Micrometer 2.0, are the New Relic team committed to releasing a new 2.x-based version? That would require them to support the Micrometer 1.x- and 2.x-based implementations in parallel.

@breedx-splk
Copy link
Contributor

Maybe @jack-berg or @jasonjkeller can add some thoughts on this.

@neiljpowell
Copy link
Contributor

neiljpowell commented Mar 7, 2022

Hi. The Insights API is not deprecated yet in NR Java Agent code (v7.x), Agent API docs or APM Custom Event docs.

The docs link shared in the issue description above, appears specific to how NR is transitioning away from Insights usage within their own products. Does NR have a roadmap for when the Insights REST API and Java Agent's API will be deprecated? That should play into the existing NR MeterRegistry support decision (who/when/where), IMO.

@jack-berg
Copy link

I think deprecating the registry here and directing users to the New Relic maintained [registry]

This is what is preferred from New Relic's perspective.

Given the breaking API changes that are coming in Micrometer 2.0, are the New Relic team committed to releasing a new 2.x-based version?

The team that maintains micrometer-registry-newrelic has been informed about the changes in Micrometer 2.0 and is deciding on whether to release a 2.x-based version.

@shakuzen shakuzen modified the milestones: 1.9 backlog, 1.10 backlog May 11, 2022
@shakuzen shakuzen modified the milestones: 1.10.x, 1.next Nov 14, 2022
@marcingrzejszczak
Copy link
Contributor

@jack-berg @neiljpowell we're not going to plan a 2.0 release any time soon. How can we proceed with this in the best way for our community?

@marcingrzejszczak marcingrzejszczak added the waiting for feedback We need additional information before we can continue label Dec 22, 2023
@jack-berg
Copy link

Ok so a several things have changed since this issue was originally opened and I think we're in a place where we can do something definitive.

Under the same reasoning that New Relic archived support for newrelic/micrometer-registry-newrelic in favor of an OTLP / OpenTelemetry solution, I think its fair to archive / delete / deprecate (whatever your end-of-life strategy is) micrometer-registry-newrelic. Instead, users can use the mcirometer OTLP registry, or the OpenTelemetry micrometer shim with the OpenTelemetry SDK configured to use the OTLP exporter.

https://docs.newrelic.com/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/get-started/opentelemetry-set-up-your-app/

@marcingrzejszczak marcingrzejszczak added feedback-provided and removed waiting for feedback We need additional information before we can continue labels Jan 2, 2024
@neiljpowell
Copy link
Contributor

neiljpowell commented Jan 2, 2024

@marcingrzejszczak @jack-berg Hi. Sorry for the delayed response. NewRelic's move to OTLP as the preferred approach for 3rd-party / non-Java Agent custom metric collection makes sense. However, collection of custom metrics via Java Agent Insights API still has not been deprecated per their latest Docs and Javadoc. This lends me to believe that the NewRelicInsightsAgentClientProvider can still be a valid NewRelicMeterRegistry option for users of their Java Agent.

@jack-berg
Copy link

The docs you reference are for sending custom event data. Sending metric data via the event protocol is like fitting a square peg in a round whole, and results in suboptimal and / or incorrect results in the UI compared to sending those metrics via OTLP. Additionally, its uncommon for folks to use the protocol directly - its much more common use the programatic APIs implemented by New Relic's various language agents.

I'm not sure what is accomplished by keeping the NewRelicMeterRegistry option around. We (New Relic) will advise users against using it, so it seems to just be extra code to maintain with better options available and just as easy to use.

@neiljpowell
Copy link
Contributor

neiljpowell commented Jan 2, 2024

Hi. Yeah, not as optimal as the newer OTLP approach. For some background, it was equivalent to the other publishing option (NewRelicInsightsApiClientProvider) at the time. Besides the Agent API abstraction, publishing through the Agent via the MeterRegistry eliminated additional API key and Account Id management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement feedback-provided registry: new relic A New Relic Registry related issue
Projects
None yet
Development

No branches or pull requests

7 participants