Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for the Observation API #3370

Closed
jonatan-ivanov opened this issue Aug 23, 2022 · 0 comments · Fixed by #3361
Closed

Add benchmarks for the Observation API #3370

jonatan-ivanov opened this issue Aug 23, 2022 · 0 comments · Fixed by #3361
Labels
enhancement A general enhancement module: benchmarks An issue that is related to our performance tests
Milestone

Comments

@jonatan-ivanov
Copy link
Member

Add benchmarks so that we can compare the Observation API with other ways of recordings.

  • Add benchmarks for comparing the Observation API with Timer + LongTaskTimer
  • Add benchmarks for NoopObservation and an uninstrumented case
  • Add benchmark for ObservationOrTimerCompatibleInstrumentation
  • Use @BenchmarkMode(Mode.SampleTime)
  • Add different scenarios to test this with and without contention (one/multiple threads)
  • Include the GC profiler so that we can see how much garbage is generated
  • Check if we can run these against some existing instrumentation where we can use fakes (i.e.: no outgoing call); this might be more realistic
@jonatan-ivanov jonatan-ivanov added module: benchmarks An issue that is related to our performance tests enhancement A general enhancement labels Aug 23, 2022
@jonatan-ivanov jonatan-ivanov added this to the 1.10.0-M5 milestone Aug 23, 2022
@jonatan-ivanov jonatan-ivanov linked a pull request Aug 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement module: benchmarks An issue that is related to our performance tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants