Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable downloadBaseline task for micrometer-jetty11 #3481

Merged
merged 1 commit into from Oct 10, 2022
Merged

Disable downloadBaseline task for micrometer-jetty11 #3481

merged 1 commit into from Oct 10, 2022

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 8, 2022

This PR disables the downloadBaseline task for the micrometer-jetty11 module.

@izeye
Copy link
Contributor Author

izeye commented Oct 8, 2022

I'm not sure why, but in #3480 it thinks it's 1.6.0-SNAPSHOT, not 1.10.0-SNAPSHOT somehow as follows:

> Configure project :
Inferred project: micrometer, version: 1.6.0-SNAPSHOT
I'm configuring micrometer with version 1.6.0-SNAPSHOT

So the condition in the micrometer-jetty11/build.gradle didn't work.

This PR changes the way to disable the downloadBaseline task for the micrometer-jetty11 module by aligning with the other modules that have been introduced in 1.10.x.

See https://app.circleci.com/pipelines/github/izeye/micrometer/922/workflows/c07e9396-0843-48b0-b596-56e9773aebb3/jobs/2107

@izeye izeye mentioned this pull request Oct 8, 2022
Merged
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 8, 2022

⚠️ 10 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

shakuzen
shakuzen approved these changes Oct 10, 2022
View reviewed changes
build.gradle
@@ -324,7 +324,7 @@ subprojects {

check.dependsOn("testModules")

if (!(project.name in ['micrometer-commons', 'micrometer-observation', 'micrometer-observation-conventions', 'micrometer-observation-test'])) {
if (!(project.name in ['micrometer-commons', 'micrometer-observation', 'micrometer-observation-conventions', 'micrometer-observation-test', 'micrometer-jetty11'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make an issue for 1.11 to remove these. Otherwise, I think it will be easy to forget.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: #3486

@shakuzen shakuzen added the type: task A general task label Oct 10, 2022
@shakuzen shakuzen added this to the 1.10.0-RC1 milestone Oct 10, 2022
@shakuzen shakuzen merged commit 26a8dda into micrometer-metrics:main Oct 10, 2022
@izeye izeye deleted the download-baseline-jetty11 branch October 10, 2022 06:34
@jonatan-ivanov jonatan-ivanov mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov left review comments

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.10.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@izeye @jonatan-ivanov @shakuzen