Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException in DefaultJmsProcessObservationConvention #4966

Closed
shakuzen opened this issue Apr 16, 2024 · 7 comments
Closed

NullPointerException in DefaultJmsProcessObservationConvention #4966

shakuzen opened this issue Apr 16, 2024 · 7 comments
Assignees
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component
Milestone

Comments

@shakuzen
Copy link
Member

          The same problem occurs in io.micrometer.jakarta9.instrument.jms.DefaultJmsProcessObservationConvention line 113 (version 1.12.4). Shall I create a new issue or should this one be reopened?

Originally posted by @toellrich in #4505 (comment)

@shakuzen shakuzen added this to the 1.12.x milestone Apr 16, 2024
@shakuzen shakuzen added bug A general bug instrumentation An issue that is related to instrumenting a component labels Apr 16, 2024
@shakuzen shakuzen modified the milestones: 1.12.x, 1.12.6 Apr 16, 2024
@shakuzen shakuzen self-assigned this Apr 16, 2024
@shakuzen
Copy link
Member Author

The fix will be available in snapshots in about 5 minutes. Would you be able to test them out and let us know if we've missed anything else, @toellrich?

@toellrich
Copy link

Sure, where can I get those snapshots, @shakuzen?

@jonatan-ivanov
Copy link
Member

@toellrich You can find the snapshot repo url in the readme.

@toellrich
Copy link

toellrich commented Apr 17, 2024

Hmm, don't know what's going on here. I added the following to my Maven POM:

  <repositories>
    <repository>
      <id>repo.spring.io</id>
      <url>https://repo.spring.io/snapshot</url>
    </repository>	  
  </repositories>

But I'm getting the following error:

[INFO] Scanning for projects...
[INFO] Downloading from repo.spring.io: https://repo.spring.io/snapshot/io/micrometer/micrometer-bom/latest.integration/micrometer-bom-latest.integration.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/micrometer/micrometer-bom/latest.integration/micrometer-bom-latest.integration.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Non-resolvable import POM: The following artifacts could not be resolved: io.micrometer:micrometer-bom:pom:latest.integration (absent): Could not find artifact io.micrometer:micrometer-bom:pom:latest.integration in repo.spring.io (https://repo.spring.io/snapshot)
...

@shakuzen
Copy link
Member Author

Sorry, the README instructions were not clear. I don't think latest.integration will work with Maven for a version. I could have been more clear. The fix is in version 1.12.6-SNAPSHOT from the snapshot repo.

@toellrich
Copy link

The error seems to be fixed. I didn't notice any other issues. Thanks!

@shakuzen
Copy link
Member Author

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component
Projects
None yet
Development

No branches or pull requests

3 participants