Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpanFilter - an option to mutate FinishedSpans #25

Closed
marcingrzejszczak opened this issue May 19, 2022 · 0 comments
Closed

Add SpanFilter - an option to mutate FinishedSpans #25

marcingrzejszczak opened this issue May 19, 2022 · 0 comments
Labels
breaking-change enhancement New feature or request
Milestone

Comments

@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented May 19, 2022

Currently SpanFilter is a global way of filtering out whether a FinishedSpan should be exported or not. We should rename SpanFilter to SpanExportingPredicate to avoid confusion. SpanFilter then would give an option to mutate spans before they are reported to a n external system. We want to keep consistent nomenclature with ObservationFilter and MeterFilter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant