Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertificateEvent should contain cert chain #73

Open
michaelkoetter opened this issue Sep 4, 2020 · 3 comments
Open

CertificateEvent should contain cert chain #73

michaelkoetter opened this issue Sep 4, 2020 · 3 comments

Comments

@michaelkoetter
Copy link

It looks like the cert chain is already saved to disk in "domain.crt", but CertificateEvent only contains the first certificate of this chain. Thus the SslContext is setup with the first cert only.

This will lead to issues with some clients (e.g. curl) which expect the chain to be present.
@msgilligan msgilligan mentioned this issue Jul 13, 2021
Closed
@zendern zendern mentioned this issue Jul 19, 2021
Merged
@zendern
Copy link
Collaborator

zendern commented Jul 19, 2021

PR official open in draft mode. I need to do some more full project level testing but I believe this should fix the issue.

@recursivecodes
Copy link

Any progress on this @zendern?

@michaelkoetter
Copy link
Author

This was merged and is now fixed in v3.1.0, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zendern @michaelkoetter @recursivecodes