Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty DefaultHttpClient logs "BUG - Handler not removed" after adding logbook #10514

Open
balapal opened this issue Feb 19, 2024 · 1 comment
Labels
type: bug Something isn't working type: docs

Comments

@balapal
Copy link

balapal commented Feb 19, 2024

Expected Behavior

I have added the logbook client handler to the netty pipeline as per documented at https://docs.micronaut.io/latest/guide/#nettyClientPipeline

It properly logs the request/response, but started to see this WARN level log messages:
[client-nioEventLoopGroup-4-1] WARN i.m.h.client.netty.DefaultHttpClient - BUG - Handler not removed: ChannelHandlerContext[logbook, [id: 0x34d2..., L:/ipAddress:port - R:domain/ipAddress:port])

I have tried to find the in the micronaut code base where that log message could come from, but didn't find it.

Actual Behaviour

No response

Steps To Reproduce

  1. Create an HTTP client annotated with micronaut's @client
  2. Add the LogbookNettyClientCustomizer as per the documentation: https://docs.micronaut.io/latest/guide/#nettyClientPipeline
  3. Call the method of the HTTP Client

Environment Information

JDK 17

Example Application

https://docs.micronaut.io/latest/guide/#nettyClientPipeline

Version

4.3.6

@yawkat yawkat added type: bug Something isn't working type: docs labels Feb 20, 2024
@yawkat
Copy link
Member

yawkat commented Feb 20, 2024

annoying. it needs to stay in onRequestPipelineBuilt for http2 but has to go into onStreamPipelineBuilt for http1. and it may break entirely in a future update where i replace pipeliningserverhandler for http2. the perils of messing with the handler pipeline directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: docs
Projects
None yet
Development

No branches or pull requests

2 participants