Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptor should intercept non-abstract methods for abstract classes #10850

Merged
merged 1 commit into from
May 24, 2024
Merged

Interceptor should intercept non-abstract methods for abstract classes #10850

merged 1 commit into from
May 24, 2024

Conversation

dstepanov
Copy link
Contributor

@dstepanov dstepanov added the type: bug Something isn't working label May 23, 2024
graemerocher
graemerocher requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks Kotlin tests

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
63.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@graemerocher graemerocher merged commit 47455d9 into 4.5.x May 24, 2024
16 of 17 checks passed
@graemerocher graemerocher deleted the intro branch May 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
No open projects
4.5.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@Transactional annotation misbehavior
2 participants
@dstepanov @graemerocher