Default method parameters on Micronaut Data interface are not validated

[ilopmar]

Parameters in a default method in a Micronaut Data repository are not validated. This doesn't happen with other methods defined in the interface that Micronaut implements.

Steps to Reproduce

Entity and DTO:

@Entity
@Table(name = "SENSOR")
public class SensorEntity {

    @Id
    @GeneratedValue
    private Long id;
    // more fields, constructor, getters/setters
   ...
}

@Introspected
public class Sensor {

    private Long id;
    // more fields, constructor, getters/setters
   ...
}

Micronaut Data interface:

@Validated
@JdbcRepository(dialect = Dialect.MYSQL)
public interface SensorRepository extends CrudRepository<SensorEntity, Long> {

    default Optional<Sensor> findSensorById(@Nonnull @NotNull Long id) {
        return Optional.empty();
    }
}

Spock Test:

    @Unroll
    void 'test "findSensorById(#id)" triggers ConstraintViolationException'() {
        when:
        sensorRepository.findSensorById(id)

        then:
        def e = thrown(ConstraintViolationException)
        e.constraintViolations.collect { it.propertyPath.toString() }.any { it.contains(field) }
        e.constraintViolations.collect { it.message }.any { it.contains(errorMessage) }

        where:
        id   | field               | errorMessage
        null | 'findSensorById.id' | 'must not be null'
    }

Expected Behaviour

The test should pass.

Actual Behaviour

The test fails with:

Expected exception of type 'javax.validation.ConstraintViolationException', but no exception was thrown
Expected exception of type 'javax.validation.ConstraintViolationException', but no exception was thrown
	at org.spockframework.lang.SpecInternals.checkExceptionThrown(SpecInternals.java:80)
	at org.spockframework.lang.SpecInternals.thrownImpl(SpecInternals.java:67)
	at mn.data.defmethod.SensorRepositoryConstraintsSpec.test "findSensorById(#id)" triggers ConstraintViolationException(SensorRepositoryConstraintsSpec.groovy:22)

Please note that if from the default method I call another method like findById then the test fails with the following error referencing findById instead of the original method.

e.constraintViolations.collect { it.propertyPath.toString() }.any { it.contains(field) }
| |                    |                                      |
| |                    [findById.id]                          false
| [io.micronaut.validation.validator.DefaultValidator$DefaultConstraintViolation@202479c0]
javax.validation.ConstraintViolationException: findById.id: must not be null

Environment Information

• Operating System: Linux Mint
• Micronaut Version: 1.3.0.RC1
• JDK Version: OpenJDK 11

Example Application

https://github.com/ilopmar/mn-data-default-method-validation

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[graemerocher]

Fixed in core