Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micronaut-data-spring brings hibernate, spring-data-commons dependencies #627

Closed
cemo opened this issue Jun 26, 2020 · 1 comment · Fixed by #775
Closed

micronaut-data-spring brings hibernate, spring-data-commons dependencies #627

cemo opened this issue Jun 26, 2020 · 1 comment · Fixed by #775

Comments

@cemo
Copy link
Contributor

cemo commented Jun 26, 2020

I was trying to use micronaut-data-spring for bridging our Spring Boot application with Micronaut Data. However I noticed that micronaut-data-spring has dependencies to hibernate, spring-data-commons. I was not expecting this actually. I think these dependencies can be optional.

It may be better to make them optional? Otherwise unpleasant surprises may come up. For example I am only interested in jdbc package of micronaut-data-spring but hibernate and spring-data dependencies are transitively appear in my classpath. On my side I was expecting only glue code with Spring and Micronaut. However I got hibernate dependencies on my classpath. :) The problem is that these packages are triggering other Micronaut features which are mostly activated presence of a class in classpath.

@graemerocher
Copy link
Contributor

Good points. Seems like some of the dependencies should be in https://github.com/micronaut-projects/micronaut-data/tree/master/data-spring-jpa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants