Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lettuce latency metrics #121

Closed
racevedoo opened this issue Sep 30, 2020 · 8 comments · Fixed by #165
Closed

Support lettuce latency metrics #121

racevedoo opened this issue Sep 30, 2020 · 8 comments · Fixed by #165
Labels
status: pr submitted A pull request has been submitted for the issue type: enhancement New feature or request

Comments

@racevedoo
Copy link
Collaborator

Hi all!

Are there any plans to support lettuce command latency metrics? Shouldn't be too hard to implement using micrometer.

@ilopmar ilopmar added the type: enhancement New feature or request label Sep 30, 2020
@ilopmar
Copy link
Contributor

ilopmar commented Sep 30, 2020

Not yet, but of course PRs welcome :)

@racevedoo
Copy link
Collaborator Author

Sure! I'll try to come up with a draft

@racevedoo
Copy link
Collaborator Author

racevedoo commented Nov 24, 2020

@ilopmar seems like lettuce 6.0 changed the way to collect metrics a bit, as stated here.

I see that there's an open PR that bumps the lettuce version to 6.0.1, so I'd like to start implementing this using 6.0 already. Is there any problem? How should I proceed? Thanks!!

@graemerocher
Copy link
Contributor

@ilopmar we will need to bump the major version of the project

@ilopmar
Copy link
Contributor

ilopmar commented Nov 24, 2020

Before we can bump a major version of a dependency and include it in a minor Micronaut version, we need to make sure that there are no breaking changes in that module. In case there are breaking changes we need to think carefully if they will accept users' applications and how. I see that the PR with the upgrade pass all the test, that's a good start :-)

Another thing that we need to test before the upgrade is the GraalVM integration. We already have a test application so we need to use it and make sure everything still works.

Yes, you can start working on that and we could include a major version of this module in Micronaut 2.3.

@ilopmar
Copy link
Contributor

ilopmar commented Feb 25, 2021

Upgraded to Lettuce 6.0.2 in #123 and released in Micronaut Redis 4.0.0

@ilopmar ilopmar closed this as completed Feb 25, 2021
@racevedoo
Copy link
Collaborator Author

@ilopmar do we support latency metrics with the upgrade? I guess that was the original issue

@ilopmar
Copy link
Contributor

ilopmar commented Feb 26, 2021

No, there is nothing built-it for doing that. I though it was only a matter of upgrading to 6.0.

@ilopmar ilopmar reopened this Feb 26, 2021
@pgressa pgressa added the status: pr submitted A pull request has been submitted for the issue label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pr submitted A pull request has been submitted for the issue type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants