Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionSecurityFilterOrderProvider should be in security instead of security-session #1

Closed
sdelamo opened this issue Apr 16, 2019 · 1 comment
Closed

SessionSecurityFilterOrderProvider should be in security instead of security-session #1

sdelamo opened this issue Apr 16, 2019 · 1 comment
Assignees
@jameskleeh
Milestone
1.2.0

Comments

@sdelamo
Copy link
Contributor

sdelamo commented Apr 16, 2019

SessionSecurityFilterOrderProvider should be in security annotated with @Requires(beans = {HttpSessionFilter.class}) with a compileOnly dependency to session instead of inside the security-session module.

it will achieve correct filter order even if the user is not including the security-session module.
@jameskleeh jameskleeh transferred this issue from micronaut-projects/micronaut-core Apr 18, 2019
@jameskleeh
Copy link
Contributor

This was resolved with https://github.com/micronaut-projects/micronaut-security/blame/d54b57ba52df9ae05068593d3c0c1966ce5d0050/security/src/main/java/io/micronaut/security/filters/SessionSecurityFilterOrderProvider.java

@jameskleeh jameskleeh added this to the 1.2.0 milestone May 17, 2019
@jameskleeh jameskleeh self-assigned this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskleeh jameskleeh

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@sdelamo @jameskleeh