Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerRequestMeterRegistryFilter is not invoked in case of 401 #5

Closed
3 of 4 tasks
luckyswede opened this issue Mar 8, 2019 · 1 comment
Closed
3 of 4 tasks
Labels
closed: duplicate This issue or pull request already exists

Comments

@luckyswede
Copy link

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem uploaded to Github
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Enable security
  2. Enable metrics
  3. Invoke endpoint that requires auth, but without credentials

Expected Behaviour

http.server metrics with status=401 should be reported

Actual Behaviour

No metrics reported for the request.
I suspect the auth handling is done before server-filters are invoked.

Environment Information

  • Operating System: All
  • Micronaut Version: 1.0.4
  • JDK Version: 11

Example Application

  • TODO:
@jameskleeh jameskleeh transferred this issue from micronaut-projects/micronaut-core Apr 18, 2019
@jameskleeh
Copy link
Contributor

This was fixed in micronaut-security 1.2.3

@jameskleeh jameskleeh added the closed: duplicate This issue or pull request already exists label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants