Skip to content

Commit

Permalink
code refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
bugthesystem committed Feb 2, 2016
1 parent 7a9cfb2 commit 5886257
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "microphone-restify",
"version": "1.0.1",
"version": "1.1.0",
"description": "Restify.js provider for microphone.js Microservice framework",
"main": "lib/index.js",
"scripts": {
Expand All @@ -24,7 +24,7 @@
],
"license": "ISC",
"dependencies": {
"microphone-core": "^1.0.2",
"microphone-core": "^1.1.0",
"restify": "^4.0.3"
},
"devDependencies": {
Expand Down
22 changes: 20 additions & 2 deletions src/restify-provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,44 @@ import {FrameworkProvider} from 'microphone-core'
import restify from 'restify';
import StatusController from './status'

/**
*
*/
export default class RestifyProvider extends FrameworkProvider {

/**
*
* @param configuration
* @param logger
*/
constructor(configuration, logger) {
super();
this._configuration = configuration;
this._logger = logger;
}

/**
*
* @param server
* @param serviceName
* @param version
* @returns {Promise}
*/
start(server, serviceName, version) {

let app = server || restify.createServer();
var port = this._configuration.getPort() || 8080;
app.get('/status', StatusController.respond);
let uri = `http://localhost:${port}`;

return new Promise((resolve, reject)=> {

app.get('/status', StatusController.respond);

app.listen(port, (err) => {
if (err) return reject(err);

this._logger.info(`Example app listening on port ${port}!`);
resolve(app);
resolve({serverInstance: app, uri: uri});
});
});
}
Expand Down
4 changes: 2 additions & 2 deletions tests/restify-provider.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ describe("RestifyProvider:", () => {
configurationMock.expects("getPort").returns(port).once();
loggerMock.expects("info").withArgs(`Example app listening on port ${port}!`).once();

let serverInstance = await restifyProvider.start(server, "test-svc", "v1");
let result = await restifyProvider.start(server, "test-svc", "v1");

request(`http://localhost:${port}/status`, (error, response, body)=> {

(!!error).should.be.equal(false);

body.should.be.equal(statusResponse);

serverInstance.close();
result.serverInstance.close();
done();
});
}
Expand Down

0 comments on commit 5886257

Please sign in to comment.