Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Default port in schur complementary portfolio #35

Open
HugoDelatte opened this issue Mar 12, 2024 · 1 comment
Open

[BUG] Default port in schur complementary portfolio #35

HugoDelatte opened this issue Mar 12, 2024 · 1 comment

Comments

@HugoDelatte
Copy link

In hierarchical_schur_complementary_portfolio_with_defaults, the default port is diagonal_portfolio_factory

It is called here with the covariance as a positional argument.
However, diagonal_portfolio_factory takes pre as it's first positional argument (here) meaning that the allocation is not an inverse variance.

I think it should be port(cov=cov) as opposed to port(cov) (with that change, the allocation will be homogenous to HRP when gamma=0)

@microprediction
Copy link
Owner

Nice catch I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants